fix(key-auth): retain order of query arguments when hiding the creden…

…tials Fixes #12758 reported by @battlebyte. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
Kong · Sep 4, 2024 · e2aa888 · e2aa888
1 parent c2459c7
commit e2aa888
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/changelog/unreleased/kong/fix-key-auth-retain-query-order.yml b/changelog/unreleased/kong/fix-key-auth-retain-query-order.yml
@@ -0,0 +1,3 @@
+message: Fixed *key-auth* to retain order of query arguments when hiding the credentials.
+type: bugfix
+scope: Plugin
diff --git a/kong/plugins/key-auth/handler.lua b/kong/plugins/key-auth/handler.lua
@@ -143,8 +143,7 @@ local function do_authentication(conf)
       key = v
 
       if conf.hide_credentials then
-        query[name] = nil
-        kong.service.request.set_query(query)
+        kong.service.request.clear_query_arg(name)
         kong.service.request.clear_header(name)
 
         if conf.key_in_body then