Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): record http.status_code even when request is not proxied #11152

Closed
wants to merge 5 commits into from
Closed

fix(tracing): record http.status_code even when request is not proxied #11152

wants to merge 5 commits into from

Conversation

backjo
Copy link
Contributor

@backjo backjo commented Jun 29, 2023 •
edited
Loading

Summary

This PR invokes instrumentation when kong requests are not proxied to the upstream, so that the
relevant span attributes are set on all requests.

Checklist

Full changelog

  • Fix: record http.status_code even when request is not proxied

Issue reference

Fix #11141

@kikito kikito requested a review from locao August 8, 2023 17:13
@locao locao mentioned this pull request Aug 14, 2023
Merged
3 tasks
@backjo backjo closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locao locao Awaiting requested review from locao

Assignees
No one assigned
Labels
changelog core/proxy size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracing: http.status_code attribute is not set when requests are not proxied
2 participants
@backjo @locao