fix(wasm/config): correctly map inherited directives #11251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
reviewed
Jul 19, 2023
gszr
force-pushed
the
fix/wasm-inherited-directives
branch
from
63def32
to
164b049
Compare
flrgh
reviewed
Jul 19, 2023
gszr
force-pushed
the
fix/wasm-inherited-directives
branch
from
164b049
to
4d82a90
Compare
flrgh
reviewed
Jul 19, 2023
gszr
force-pushed
the
fix/wasm-inherited-directives
branch
from
4d82a90
to
2100a00
Compare
flrgh
reviewed
Jul 19, 2023
flrgh
approved these changes
Jul 19, 2023
The Kong Wasm integration inherits certain configuration properties defined for Kong; among others, it inherits injected Nginx directives. As implemented in #11218, the integration inherited certain directives from the `ngx_http_proxy_module`, while the desired behavior is to inherit from the `ngx_lua_module`, so that Lua and Wasm extensions operate under the same settings. This commit implements that change.
Remove warning when `wasm=off` and Wasm directives are set. The team agrees such a warning does not provide much value as the user may toggle Wasm on and off temporarily for testing.
gszr
force-pushed
the
fix/wasm-inherited-directives
branch
from
eb33df4
to
d2f6969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This addresses some of the outstanding feedback from @thibaultcha on the Wasm integration PR.