Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*): raise the default size limit of cosocket connection pool fr… #11268

Merged
merged 1 commit into from
Jul 25, 2023
Merged

chore(*): raise the default size limit of cosocket connection pool fr… #11268

merged 1 commit into from
Jul 25, 2023

Conversation

outsinre
Copy link
Contributor

@outsinre outsinre commented Jul 24, 2023 •
edited by jira bot
Loading

Summary

Raise the default size limit of cosocket connection pool from 30 to 256

The current default value 30 is extremely conservative and easily choke under high concurrency. We should raise it to 256 to start with.

Checklist

Full changelog

  • raise the default size limit of cosocket connection pool from 30 to 256

Issue reference

Fix #FTI-5215

@outsinre
Copy link
Contributor Author

Will cherry-pick to EE and additionally EE plugins.

@windmgc windmgc merged commit 647be45 into master Jul 25, 2023
26 checks passed
@windmgc windmgc deleted the FTI-5215-bump-default-value-of-lua-socket-pool-size branch July 25, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windmgc windmgc windmgc approved these changes

@chronolaw chronolaw chronolaw approved these changes

Assignees

@outsinre outsinre

Labels
core/templates schema-change-noteworthy size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@outsinre @windmgc @chronolaw