Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): clean the logic of get_upstream_uri_v0() #11278

Merged
merged 2 commits into from
Jul 31, 2023
Merged

refactor(router): clean the logic of get_upstream_uri_v0() #11278

merged 2 commits into from
Jul 31, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jul 25, 2023 •
edited
Loading

Summary

The code of function get_upstream_uri_v0() is too complex,
this PR tries to clean the logic by using early return.

KAG-2148

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@chronolaw chronolaw marked this pull request as ready for review July 25, 2023 07:35
@fffonion fffonion merged commit 1367fa3 into master Jul 31, 2023
20 checks passed
@fffonion fffonion deleted the refactor/router_get_upstream_uri_v0 branch July 31, 2023 07:24
@chronolaw chronolaw mentioned this pull request Jul 31, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion approved these changes

Assignees

@chronolaw chronolaw

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chronolaw @fffonion