Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cd): enable arm64 for rhel-9 and aws-2023 #11334

Merged
merged 4 commits into from
Aug 3, 2023
Merged

feat(cd): enable arm64 for rhel-9 and aws-2023 #11334

merged 4 commits into from
Aug 3, 2023

Conversation

fffonion
Copy link
Contributor

Summary

Enables arm64 build on rpm distros for CE.

https://github.com/Kong/kong-ee/pull/6152

Checklist

Full changelog

  • feat(build): cross compile rpm platforms
  • feat(cd): release rhel9 and aws2023 arm64 artifacts

Issue reference

KAG-2184

Replaces #11242

@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed build/bazel labels Jul 31, 2023
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Aug 1, 2023
@fffonion fffonion force-pushed the rhel-cross branch 3 times, most recently from 0cb7a09 to fa2121c Compare August 1, 2023 10:24
@kikito kikito requested a review from zhongweiy August 1, 2023 17:05
.github/matrix-full.yml Show resolved Hide resolved
container:
image: ${{ matrix.image }}
options: --privileged

steps:
- name: Early Rpm Setup
if: matrix.package == 'rpm'
if: matrix.package == 'rpm' && matrix.image != ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From line 105, it seems run only on Ubuntu. Then is this matrix.package == 'rpm' check valid?

Copy link
Contributor Author

@fffonion fffonion Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhongweiy currently, we run following builds a on bare ubuntu runner (VM):

  • ubuntu-22.04 builds x86 + arm64 (crossbuild)
  • rhel9, aws2023 arm64 (crossbuild) <= this PR was doing this

the following are ran in a container inside a ubuntu runner VM:

  • all rpm platforms (rhel, centos, aws etc) in x86
  • debian x86 + arm64
  • ubuntu 20.04 x86

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks for the explanation!

build/toolchain/managed_toolchain.bzl Show resolved Hide resolved
@fffonion
Copy link
Contributor Author

fffonion commented Aug 2, 2023

@fffonion fffonion merged commit edf3fce into master Aug 3, 2023
21 checks passed
@fffonion fffonion deleted the rhel-cross branch August 3, 2023 06:42
@team-gateway-bot
Copy link
Collaborator

The backport to release/3.4.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.4.x release/3.4.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.4.x
# Create a new branch
git switch --create backport-11334-to-release/3.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 edf3fce26f999bc7c8d090610f6bb2d1f0dd254b
# Push it to GitHub
git push --set-upstream origin backport-11334-to-release/3.4.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.4.x

Then, create a pull request where the base branch is release/3.4.x and the compare/head branch is backport-11334-to-release/3.4.x.

@fffonion
Copy link
Contributor Author

fffonion commented Aug 3, 2023

i will hold backport to 3.4.x after GA; this is not a requirement for release and we can hold for more tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/bazel chore Not part of the core functionality of kong, but still needed size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants