-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cd): enable arm64 for rhel-9 and aws-2023 #11334
Conversation
0cb7a09
to
fa2121c
Compare
container: | ||
image: ${{ matrix.image }} | ||
options: --privileged | ||
|
||
steps: | ||
- name: Early Rpm Setup | ||
if: matrix.package == 'rpm' | ||
if: matrix.package == 'rpm' && matrix.image != '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From line 105, it seems run only on Ubuntu. Then is this matrix.package == 'rpm'
check valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhongweiy currently, we run following builds a on bare ubuntu runner (VM):
- ubuntu-22.04 builds x86 + arm64 (crossbuild)
- rhel9, aws2023 arm64 (crossbuild) <= this PR was doing this
the following are ran in a container inside a ubuntu runner VM:
- all rpm platforms (rhel, centos, aws etc) in x86
- debian x86 + arm64
- ubuntu 20.04 x86
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks for the explanation!
Good run for packaging https://github.com/Kong/kong/actions/runs/5725602451/job/15514422915 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.4.x release/3.4.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.4.x
# Create a new branch
git switch --create backport-11334-to-release/3.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 edf3fce26f999bc7c8d090610f6bb2d1f0dd254b
# Push it to GitHub
git push --set-upstream origin backport-11334-to-release/3.4.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.4.x Then, create a pull request where the |
i will hold backport to 3.4.x after GA; this is not a requirement for release and we can hold for more tests |
Summary
Enables arm64 build on rpm distros for CE.
https://github.com/Kong/kong-ee/pull/6152
Checklist
Full changelog
Issue reference
KAG-2184
Replaces #11242