feat(explain_manifest): add ability to test docker images as well #11349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
fffonion
force-pushed
the
manifest-docker
branch
from
6446f93
to
8f57aaf
Compare
fffonion
force-pushed
the
manifest-docker
branch
2 times, most recently
from
2e00251
to
3408fbc
Compare
windmgc
approved these changes
Aug 7, 2023
fffonion
force-pushed
the
manifest-docker
branch
from
3408fbc
to
9fc7173
Compare
fffonion
force-pushed
the
manifest-docker
branch
from
9fc7173
to
442abee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, the static analysis part in "Legacy Smoke Test" is moved to "Verify Manifest - Images".
We will move the e2e test part of "Legacy Smoke Test" in sepearte workflow (possibly e2e api tests) and remove
smoke tests.
Not required by 3.4 release.
Checklist
Full changelog
Issue reference
https://github.com/Kong/kong-ee/pull/6024
KAG-1388