fix(acme): error concatenation #11364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mierenga
approved these changes
Aug 7, 2023
|
@zekth Could you add an entry in CHANGELOG.md? I think we can skip add test for this though. |
zekth
force-pushed
the
fix/acme-plugin-logs
branch
from
333b1a1
to
bcdf45d
Compare
|
done and rebased :) |
fffonion
approved these changes
Aug 8, 2023
|
Thanks @zekth ! |
team-gateway-bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
In the last change we added string concatenation the wrong way leading to empty logs. This addresses the problem (cherry picked from commit 60b4312)
gszr
pushed a commit
that referenced
this pull request
Nov 14, 2023
In the last change we added string concatenation the wrong way leading to empty logs. This addresses the problem (cherry picked from commit 60b4312)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the last change we added string concatenation the wrong way leading to empty logs. This addresses the problem
Checklist
Full changelog
Issue reference
Fix #[issue number]