Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release/3.4.x] fix(acme): error concatenation #11365

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[Backport release/3.4.x] fix(acme): error concatenation #11365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@
[#10559](https://github.com/Kong/kong/pull/10559)
- **Zipkin**: Fixed an issue that traces not being generated correctly when instrumentations are enabled.
[#10983](https://github.com/Kong/kong/pull/10983)
- **Acme**: Fixed string concatenation on cert renewal errors
[#11364](https://github.com/Kong/kong/pull/11364)

#### PDK

Expand Down
3 changes: 2 additions & 1 deletion kong/plugins/acme/client.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ local function order(acme_client, host, key, cert_type, rsa_key_size)

local cert, err = acme_client:order_certificate(key, host)
if err then
return nil, nil, "could not create certificate for host: ", host, " err: " .. err
local concatErr = "could not create certificate for host: " .. host .. " err: " .. err
return nil, nil, concatErr
end

return cert, key, nil
Expand Down
Loading