chore(ci): upload coredump #11401
Closed
chore(ci): upload coredump #11401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
ADD-SP
force-pushed
the
add_sp/chore-upload-coredump
branch
5 times, most recently
from
c09ec6f
to
54d9ea6
Compare
ADD-SP
force-pushed
the
add_sp/chore-upload-coredump
branch
11 times, most recently
from
0d70e60
to
459dea5
Compare
fffonion
reviewed
Aug 14, 2023
ADD-SP
force-pushed
the
add_sp/chore-upload-coredump
branch
8 times, most recently
from
fd3e1a1
to
61a57c5
Compare
ADD-SP
force-pushed
the
add_sp/chore-upload-coredump
branch
from
61a57c5
to
92eb548
Compare
ADD-SP
force-pushed
the
add_sp/chore-upload-coredump
branch
4 times, most recently
from
f8c09dc
to
f3a3f17
Compare
fffonion
reviewed
Aug 16, 2023
| sudo mkdir -p ${{ env.BUILD_ROOT }}/kong-dev | ||
| sudo tar -C ${{ env.BUILD_ROOT }}/kong-dev -xzvf artifacts/build.tar.gz | ||
|
|
||
| - name: Install Kong dev |
There was a problem hiding this comment.
are those Install Kong dev steps needed?
There was a problem hiding this comment.
@fffonion It will install some dev-rocks and some binary like grpcurl.
There was a problem hiding this comment.
iirc we already installed the dev rocks on build step for ce (and cached) 🤔
There was a problem hiding this comment.
- name: Build Dev Kong dependencies
if: steps.cache-deps.outputs.cache-hit != 'true'
run: |
make install-dev-rocks
This line has been removed in this PR, to keep consistency with EE.
ADD-SP
force-pushed
the
add_sp/chore-upload-coredump
branch
from
f3a3f17
to
51e29a8
Compare
fffonion
reviewed
Aug 18, 2023
fffonion
reviewed
Aug 18, 2023
ADD-SP
force-pushed
the
add_sp/chore-upload-coredump
branch
from
51e29a8
to
1e4a11c
Compare
|
Is this still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upload core dump if it exists, it is good for troubleshooting in the local env,
Checklist
Full changelog
N/A
Issue reference
N/A