Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): address flakiness of grpc logs test #11408

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Aug 15, 2023

Summary

Let's clear the log before the test.

Checklist

Full changelog

  • clear the log before the test.
  • refactor to fail with more clear messages

Issue reference

Please remember to remove the issue reference from the commit message. It's added by mistake.

@StarlightIbuki
Copy link
Contributor Author

StarlightIbuki commented Aug 16, 2023

FAILED  spec/03-plugins/03-http-log/01-log_spec.lua:444: Plugin: http-log (log) [#postgres] logs to HTTP (#grpcs)
./spec/helpers.lua:1683: Failed to assert eventual condition

This means, it really has encountered a situation where the log is not emitted.

The fix is still needed but it does not seem to fix the real issue.

My bad. Mistakenly checking grpc instead of grpcs.

Let's clear the log before the test.

Fix KAG-1874
@fffonion fffonion merged commit d08e92e into master Aug 17, 2023
25 checks passed
@fffonion fffonion deleted the chore/flaky-grpc-log branch August 17, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants