refactor(router): categorize router fields to simplify logic #11411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
force-pushed
the
refactor/category_router_fields
branch
from
06476ff
to
584f46f
Compare
Water-Melon
approved these changes
Aug 22, 2023
chronolaw
force-pushed
the
refactor/category_router_fields
branch
from
584f46f
to
f2e7fd6
Compare
samugi
reviewed
Aug 25, 2023
samugi
approved these changes
Aug 25, 2023
chobits
reviewed
Aug 27, 2023
chobits
approved these changes
Aug 27, 2023
chronolaw
added a commit
that referenced
this pull request
Jan 24, 2024
Summary Categorize atc fields to fields header_fields query_fields, then we can simplify the logic in select().
3 tasks
chronolaw
added a commit
that referenced
this pull request
Feb 26, 2024
Summary Categorize atc fields to fields header_fields query_fields, then we can simplify the logic in select().
chronolaw
added a commit
that referenced
this pull request
Mar 4, 2024
Summary Categorize atc fields to fields header_fields query_fields, then we can simplify the logic in select().
ADD-SP
pushed a commit
that referenced
this pull request
Mar 7, 2024
Summary Categorize atc fields to fields header_fields query_fields, then we can simplify the logic in select().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Categorize atc fields to
fieldsheader_fieldsquery_fields,then we can simplify the logic in
select().Checklist
Full changelog
Issue reference
Fix #[issue number]