Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(DEVELOPER.md): fix links to busted and luacheck #12373

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

jenstroeger
Copy link
Contributor

Summary

Fix links to busted and luacheck in DEVELOPER.md

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Jan 19, 2024
@locao locao requested a review from flrgh March 5, 2024 18:01
Copy link
Contributor

@flrgh flrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @jenstroeger for the fix!

Since the links are used more than once each, I this would arguably be a good use case for reference-style markdown links, but I think it's perfectly fine to merge in its current state.

locao
locao previously requested changes Mar 19, 2024
Copy link
Contributor

@locao locao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

busted URL change suggested, to keep our docs consistent.

DEVELOPER.md Outdated Show resolved Hide resolved
DEVELOPER.md Outdated Show resolved Hide resolved
jenstroeger and others added 3 commits April 8, 2024 14:44
Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
@jschmid1 jschmid1 requested a review from locao April 8, 2024 12:45
@jschmid1 jschmid1 merged commit bff6515 into Kong:master Apr 8, 2024
4 checks passed
@locao locao changed the title docs: fix links to busted and luacheck in DEVELOPER.md docs(DEVELOPER.md): fix links to busted and luacheck in DEVELOPER.md Apr 26, 2024
@locao locao changed the title docs(DEVELOPER.md): fix links to busted and luacheck in DEVELOPER.md docs(DEVELOPER.md): fix links to busted and luacheck Apr 26, 2024
@locao locao added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Apr 26, 2024
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/docs size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants