Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): add tzdata to deb images #12609

Merged
merged 6 commits into from
Feb 29, 2024
Merged

chore(release): add tzdata to deb images #12609

merged 6 commits into from
Feb 29, 2024

Conversation

outsinre
Copy link
Contributor

@outsinre outsinre commented Feb 23, 2024 •
edited
Loading

Summary

The tzdata package supports standard timezone database info. So users can set or show accurate timezone info.

The tzdata package does not introduce other dependencies.

root@3e594c1541f2:/# apt-cache depends tzdata
tzdata
 |Depends: debconf
  Depends: <debconf-2.0>
    cdebconf
    debconf

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #FTI-5698

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Feb 23, 2024
@outsinre
Copy link
Contributor Author

Full matrix job: https://github.com/Kong/kong/actions/runs/8014240998?pr=12609

@outsinre
Copy link
Contributor Author

Will rebase after #12603.

@outsinre
chore(release): add tzdata to deb images
8818ce2 
The tzdata package supports standard timezone database info.
So users can set or show accurate timezone info.
@outsinre
revert me: run test for all matrices
1fb7ccf
@outsinre
Revert "chore(release): add tzdata to deb images"
16625d6 
This reverts commit cbb1c9598a2d0ec15fc90f976a3076570de0d253.
@outsinre
Revert "Revert "chore(release): add tzdata to deb images""
de2e261 
This reverts commit 39a9e01c85ce3e10b949920b291d65beca1b2147.
@outsinre outsinre force-pushed the FTI-5698-add-tzdata-package-to-ubuntu-based-image branch from e8ee6a5 to de2e261 Compare February 23, 2024 11:10
@outsinre
Copy link
Contributor Author

Full build: https://github.com/Kong/kong/actions/runs/8018345106?pr=12609

@outsinre @fffonion
Update changelog/unreleased/kong/add_tzdata.yml
fc4491d 
Co-authored-by: Wangchong Zhou <wangchong@konghq.com>
@fffonion fffonion merged commit 9d68f16 into master Feb 29, 2024
26 checks passed
@fffonion fffonion deleted the FTI-5698-add-tzdata-package-to-ubuntu-based-image branch February 29, 2024 08:59
@locao
Copy link
Contributor

locao commented Apr 1, 2024

@outsinre it seems to me this change should be cherry-picked to Kong-EE, what do you think?

@locao locao added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Apr 26, 2024
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

locao pushed a commit that referenced this pull request Jun 21, 2024
@outsinre @bungle
chore(package): add tzdata to deb images (#12609)
c061d59 
The tzdata package supports standard timezone database info.
So users can set or show convenient timezone info.

Fix #FTI-5698

(cherry picked from commit 9d68f16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bungle bungle bungle approved these changes

@fffonion fffonion fffonion approved these changes

Assignees

@outsinre outsinre

Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@outsinre @locao @team-gateway-bot @bungle @fffonion