Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prometheus): add workspace label to the real time metrics #12836

Merged
merged 7 commits into from
Apr 24, 2024
Merged

feat(prometheus): add workspace label to the real time metrics #12836

merged 7 commits into from
Apr 24, 2024

Conversation

oowl
Copy link
Member

@oowl oowl commented Apr 7, 2024 •
edited
Loading

Summary

add workspace label to the real-time metrics.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

FTI-5573

@github-actions github-actions bot added plugins/prometheus cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Apr 7, 2024
@oowl oowl force-pushed the feat/prometheus-workspace branch from e8eabf6 to b7c742b Compare April 18, 2024 08:17
@oowl oowl added this to the 3.7.0 milestone Apr 23, 2024
@kikito kikito requested a review from gruceo April 23, 2024 13:37
@team-eng-enablement team-eng-enablement added author/community PRs from the open-source community (not Kong Inc) and removed author/community PRs from the open-source community (not Kong Inc) labels Apr 24, 2024
@locao locao force-pushed the feat/prometheus-workspace branch from 98fe1c5 to 1b6c827 Compare April 24, 2024 14:20
@locao locao merged commit da87c42 into master Apr 24, 2024
25 checks passed
@locao locao deleted the feat/prometheus-workspace branch April 24, 2024 18:17
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

tysoekong pushed a commit that referenced this pull request Apr 26, 2024
@team-gateway-bot @oowl
feat(prometheus): add workspace label to the real time metrics (#8920)
8f583a7 
* feat(prometheus): add workspace label to the real time metrics (#12836)

Co-authored-by: Zachary Hu <6426329+outsinre@users.noreply.github.com>
(cherry picked from commit da87c42)

* fix: fix code

* fix: fix code

---------

Co-authored-by: Jun Ouyang <ouyangjun1999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsinre outsinre outsinre left review comments

@tzssangglass tzssangglass tzssangglass approved these changes

@gruceo gruceo gruceo approved these changes

@raoxiaoyan raoxiaoyan Awaiting requested review from raoxiaoyan

@fffonion fffonion Awaiting requested review from fffonion

Assignees

@oowl oowl

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/logs plugins/prometheus size/M
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
7 participants
@oowl @team-gateway-bot @outsinre @tzssangglass @gruceo @locao @team-eng-enablement