Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): reword consumers username and custom_id field description #12900

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Apr 22, 2024

Summary

username and custom_id are not mutually exclusive so use a clear wording in those fields' descriptions that do not indicate that.

@github-actions github-actions bot added core/db schema-change-noteworthy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Apr 22, 2024
@pmalek pmalek requested a review from a team April 22, 2024 13:49
Co-authored-by: Hisham Muhammad <hisham@gobolinux.org>
@pmalek pmalek requested a review from hishamhm April 22, 2024 14:19
@jschmid1 jschmid1 merged commit 5cd2b07 into master Apr 25, 2024
29 checks passed
@jschmid1 jschmid1 deleted the consumer-api-doc-rewording branch April 25, 2024 10:09
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants