Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix snappy shared library build on macOS #12939

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

fffonion
Copy link
Contributor

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Apr 25, 2024
@bungle
Copy link
Member

bungle commented Apr 25, 2024

Works:

❯ ll bazel-out/darwin_arm64-fastbuild/bin/external/snappy                           
total 392K
drwxr-xr-x 4 bungle wheel  128 Apr 25 14:55 _objs
-r-xr-xr-x 1 bungle wheel 1.7K Apr 25 14:55 config.h
-r-xr-xr-x 1 bungle wheel 1.9K Apr 25 14:55 libsnappy-stubs-internal.a
-r-xr-xr-x 1 bungle wheel 195K Apr 25 14:55 libsnappy.a.a
-r-xr-xr-x 1 bungle wheel 179K Apr 25 14:55 libsnappy.dylib
-r-xr-xr-x 1 bungle wheel  440 Apr 25 14:55 libsnappy.dylib-2.params
-r-xr-xr-x 1 bungle wheel 2.6K Apr 25 14:55 snappy-stubs-public.h

Thanks @fffonion!

@bungle bungle merged commit ec81e89 into master Apr 25, 2024
31 checks passed
@bungle bungle deleted the fix-snappy-macos branch April 25, 2024 12:06
@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Apr 25, 2024
fffonion added a commit that referenced this pull request Apr 26, 2024
This reverts commit 161fc0c894402439cf2c2a99577241d2abb3e682.
dndx pushed a commit that referenced this pull request Apr 26, 2024
This reverts commit 161fc0c894402439cf2c2a99577241d2abb3e682.
@kikito
Copy link
Member

kikito commented Apr 30, 2024

This was included in kong-ee as part of https://github.com/Kong/kong-ee/pull/8928

@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Apr 30, 2024
@Kong Kong deleted a comment from team-gateway-bot Apr 30, 2024
locao pushed a commit that referenced this pull request Jun 21, 2024
This reverts commit 161fc0c894402439cf2c2a99577241d2abb3e682.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants