-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): fix snappy shared library build on macOS #12939
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build/bazel
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Apr 25, 2024
fffonion
force-pushed
the
fix-snappy-macos
branch
from
April 25, 2024 11:36
6626910
to
66b01ff
Compare
ADD-SP
approved these changes
Apr 25, 2024
Water-Melon
approved these changes
Apr 25, 2024
Works:
Thanks @fffonion! |
bungle
approved these changes
Apr 25, 2024
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Apr 25, 2024
fffonion
added a commit
that referenced
this pull request
Apr 26, 2024
This reverts commit 161fc0c894402439cf2c2a99577241d2abb3e682.
dndx
pushed a commit
that referenced
this pull request
Apr 26, 2024
This reverts commit 161fc0c894402439cf2c2a99577241d2abb3e682.
This was included in kong-ee as part of https://github.com/Kong/kong-ee/pull/8928 |
kikito
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Apr 30, 2024
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
This reverts commit 161fc0c894402439cf2c2a99577241d2abb3e682.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build/bazel
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
size/S
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]