-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(toolchain): multiple fixes for cxx cross build and on macOS #12945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 161fc0c894402439cf2c2a99577241d2abb3e682.
github-actions
bot
added
chore
Not part of the core functionality of kong, but still needed
build/bazel
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Apr 26, 2024
fffonion
force-pushed
the
add-toolchain-config
branch
2 times, most recently
from
April 26, 2024 08:20
2b90f20
to
65a6be3
Compare
fffonion
force-pushed
the
add-toolchain-config
branch
2 times, most recently
from
April 26, 2024 09:45
dc83d26
to
49a0056
Compare
fffonion
force-pushed
the
add-toolchain-config
branch
from
April 26, 2024 09:51
7903604
to
6621f93
Compare
fffonion
force-pushed
the
add-toolchain-config
branch
from
April 26, 2024 10:07
6621f93
to
1494600
Compare
fffonion
force-pushed
the
add-toolchain-config
branch
from
April 26, 2024 10:22
1494600
to
cb3d40c
Compare
dndx
approved these changes
Apr 26, 2024
Thanks for the effort @fffonion . |
chobits
approved these changes
Apr 26, 2024
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12945-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12945-to-master-to-upstream
git checkout -b cherry-pick-12945-to-master-to-upstream
ancref=$(git merge-base a5a61d645aad3107d4c742cf9537bb4d673c8fbe cb3d40c67b426ea6232dcdb1438794461a3f33dd)
git cherry-pick -x $ancref..cb3d40c67b426ea6232dcdb1438794461a3f33dd |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Apr 26, 2024
locao
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build/bazel
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
chore
Not part of the core functionality of kong, but still needed
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cc_shared_library
but hide after analias
and not turned on outside macOS.-U_FORTIFY_SOURCE
,-fstack-protector
etc (please check sources for full list of flags)Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]