Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clustering/rpc): fix incorrect is_timeout() call introduced during #12946

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

dndx
Copy link
Member

@dndx dndx commented Apr 26, 2024

review address and adds tests for concentrator. This fixes error like:

concentrator.lua:237: [rpc] concentrator event loop error: wait_for_notification error: receive_message: failed to get type: timeout, reconnecting in 8 seconds, context: ngx.timer

Note: the reuseport change for testing fixture is needed in order to run two CP at the same time in our testing suite.

KAG-623

review address and adds tests for concentrator. This fixes error like:

```
concentrator.lua:237: [rpc] concentrator event loop error: wait_for_notification error: receive_message: failed to get type: timeout, reconnecting in 8 seconds, context: ngx.timer
```
@dndx dndx requested review from chobits and ADD-SP April 26, 2024 08:02
@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Apr 26, 2024
@dndx
Copy link
Member Author

dndx commented Apr 26, 2024

Unreleased feature, skipping changelog.

@bungle bungle merged commit 7b5add3 into master Apr 26, 2024
41 of 43 checks passed
@bungle bungle deleted the fix/concentrator_error branch April 26, 2024 08:29
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12946-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12946-to-master-to-upstream
git checkout -b cherry-pick-12946-to-master-to-upstream
ancref=$(git merge-base 5dc3b7ba3509a28b57f2421fdef7c24391585f9b fe3f8b2988d61fb24a5b50c342eea7b4bdad5900)
git cherry-pick -x $ancref..fe3f8b2988d61fb24a5b50c342eea7b4bdad5900

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Apr 26, 2024
@dndx
Copy link
Member Author

dndx commented Apr 26, 2024

I will manually cherry pick this PR as the original feature hasn't been cherry picked yet due to build issue.

@locao locao removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Apr 26, 2024
locao pushed a commit that referenced this pull request Jun 21, 2024
…ing (#12946)

review address and adds tests for concentrator. This fixes error like:

```
concentrator.lua:237: [rpc] concentrator event loop error: wait_for_notification error: receive_message: failed to get type: timeout, reconnecting in 8 seconds, context: ngx.timer
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants