Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(clustering/rpc): cache the result of parse_method_name() #12949

Merged
merged 1 commit into from
Jul 3, 2024
Merged

refactor(clustering/rpc): cache the result of parse_method_name() #12949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion kong/clustering/rpc/utils.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
local _M = {}
local cjson = require("cjson")
local snappy = require("resty.snappy")
local lrucache = require("resty.lrucache")


local string_sub = string.sub
Expand All @@ -12,13 +13,26 @@ local snappy_compress = snappy.compress
local snappy_uncompress = snappy.uncompress


local cap_names = lrucache.new(100)


function _M.parse_method_name(method)
ADD-SP marked this conversation as resolved.
Show resolved Hide resolved
local cap = cap_names:get(method)
ADD-SP marked this conversation as resolved.
Show resolved Hide resolved

if cap then
return cap[1], cap[2]
end

local pos = rfind(method, ".")
if not pos then
return nil, "not a valid method name"
end

return method:sub(1, pos - 1), method:sub(pos + 1)
local cap = { method:sub(1, pos - 1), method:sub(pos + 1) }

cap_names:set(method, cap)

return cap[1], cap[2]
end


Expand Down
Loading