Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tools/uuid): update UUID reference #12952

Merged
merged 16 commits into from
May 27, 2024
Merged

refactor(tools/uuid): update UUID reference #12952

merged 16 commits into from
May 27, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Apr 28, 2024 •
edited
Loading

Summary

We are refactoring kong.tools.*, and trying to updating all references of kong.tools.utils to proper kong.tools.uuid, which will make our code more clear and easy to maintain.

KAG-3142

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 28, 2024
@github-actions github-actions bot added core/proxy plugins/correlation-id core/wasm Everything relevant to [proxy-]wasm labels Apr 28, 2024
@chronolaw chronolaw marked this pull request as ready for review April 28, 2024 06:52
Water-Melon
Water-Melon reviewed Apr 28, 2024
View reviewed changes
kong/api/endpoints.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw force-pushed the refactor/update_uuid_reference branch from a351934 to 5f6940f Compare April 29, 2024 08:54
@chronolaw chronolaw force-pushed the refactor/update_uuid_reference branch from 5f6940f to 374bab7 Compare May 6, 2024 02:09
@chronolaw chronolaw force-pushed the refactor/update_uuid_reference branch from a68b2f3 to 8b848ab Compare May 17, 2024 09:13
hanshuebner
hanshuebner suggested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@hanshuebner hanshuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a description in your PR. The KAG link is useless for open source users.

@chronolaw
Copy link
Contributor Author

Please provide a description in your PR. The KAG link is useless for open source users.

Done, thanks.

@chronolaw
Copy link
Contributor Author

@hanshuebner , could you take a look again? thanks.

@bungle bungle merged commit aae1815 into master May 27, 2024
29 checks passed
@bungle bungle deleted the refactor/update_uuid_reference branch May 27, 2024 11:08
@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label May 27, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label May 28, 2024
@Kong Kong deleted a comment from team-gateway-bot May 28, 2024
@chronolaw chronolaw mentioned this pull request May 29, 2024
Merged
3 tasks
locao pushed a commit that referenced this pull request Jun 21, 2024
@chronolaw @hanshuebner
refactor(tools/uuid): update UUID reference (#12952)
cd675c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshuebner hanshuebner hanshuebner approved these changes

@bungle bungle bungle approved these changes

@Water-Melon Water-Melon Water-Melon approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/admin-api core/balancer core/clustering core/db/migrations core/db core/pdk core/proxy core/wasm Everything relevant to [proxy-]wasm plugins/acl plugins/correlation-id schema-change-noteworthy size/XL skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @hanshuebner @bungle @Water-Melon @kikito