-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "feat(plugins): standard-webhooks"" #12962
Merged
samugi
merged 3 commits into
master
from
revert-12961-revert-12757-feat/standard-webhooks-plugin
May 8, 2024
Merged
Revert "Revert "feat(plugins): standard-webhooks"" #12962
samugi
merged 3 commits into
master
from
revert-12961-revert-12757-feat/standard-webhooks-plugin
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
Not part of the core functionality of kong, but still needed
schema-change-noteworthy
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Apr 29, 2024
kikito
approved these changes
Apr 29, 2024
zekth
force-pushed
the
revert-12961-revert-12757-feat/standard-webhooks-plugin
branch
from
May 8, 2024 12:31
2dd99e5
to
aa72d93
Compare
samugi
reviewed
May 8, 2024
This reverts commit 8ff1771.
zekth
force-pushed
the
revert-12961-revert-12757-feat/standard-webhooks-plugin
branch
from
May 8, 2024 13:44
aa72d93
to
4a3a229
Compare
Co-authored-by: Samuele <samuele@konghq.com>
Co-authored-by: Samuele <samuele@konghq.com>
samugi
approved these changes
May 8, 2024
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12962-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12962-to-master-to-upstream
git checkout -b cherry-pick-12962-to-master-to-upstream
ancref=$(git merge-base 6374c55fb23720700bfb7c3594fa877d356b4ea9 6bc2764c86bd4d80178b85546d28d351e11279e8)
git cherry-pick -x $ancref..6bc2764c86bd4d80178b85546d28d351e11279e8 |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
May 8, 2024
kikito
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
May 14, 2024
oowl
pushed a commit
that referenced
this pull request
Jul 15, 2024
* feat(plugins): standard-webhooks (#12962) * Revert "Revert "feat(plugins): add standard-webhooks plugin (#12757)"" This reverts commit 8ff1771. * Update kong/plugins/standard-webhooks/internal.lua Co-authored-by: Samuele <samuele@konghq.com> --------- Co-authored-by: Samuele <samuele@konghq.com> (cherry picked from commit 03f056c) * fix: cherry pick * Update plugins-add-standard-webhooks.yml * Update plugins-add-standard-webhooks.yml * Update kong/plugins/standard-webhooks/handler.lua Co-authored-by: Samuele <samuele@konghq.com> * fix order --------- Co-authored-by: Samuele <samuele@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
chore
Not part of the core functionality of kong, but still needed
schema-change-noteworthy
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12961
This will have to land in 3.8
KAG-4976