Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "feat(plugins): standard-webhooks"" #12962

Merged

Conversation

zekth
Copy link
Member

@zekth zekth commented Apr 29, 2024

Reverts #12961

This will have to land in 3.8

KAG-4976

@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed schema-change-noteworthy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Apr 29, 2024
@zekth zekth force-pushed the revert-12961-revert-12757-feat/standard-webhooks-plugin branch from 2dd99e5 to aa72d93 Compare May 8, 2024 12:31
@zekth zekth marked this pull request as ready for review May 8, 2024 12:31
kong/plugins/standard-webhooks/internal.lua Outdated Show resolved Hide resolved
kong/plugins/standard-webhooks/internal.lua Outdated Show resolved Hide resolved
kong/plugins/standard-webhooks/internal.lua Show resolved Hide resolved
@zekth zekth force-pushed the revert-12961-revert-12757-feat/standard-webhooks-plugin branch from aa72d93 to 4a3a229 Compare May 8, 2024 13:44
zekth and others added 2 commits May 8, 2024 15:45
Co-authored-by: Samuele <samuele@konghq.com>
Co-authored-by: Samuele <samuele@konghq.com>
@samugi samugi merged commit 03f056c into master May 8, 2024
25 checks passed
@samugi samugi deleted the revert-12961-revert-12757-feat/standard-webhooks-plugin branch May 8, 2024 14:14
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12962-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12962-to-master-to-upstream
git checkout -b cherry-pick-12962-to-master-to-upstream
ancref=$(git merge-base 6374c55fb23720700bfb7c3594fa877d356b4ea9 6bc2764c86bd4d80178b85546d28d351e11279e8)
git cherry-pick -x $ancref..6bc2764c86bd4d80178b85546d28d351e11279e8

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label May 8, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label May 14, 2024
oowl pushed a commit that referenced this pull request Jul 15, 2024
* feat(plugins): standard-webhooks (#12962)

* Revert "Revert "feat(plugins): add standard-webhooks plugin (#12757)""

This reverts commit 8ff1771.

* Update kong/plugins/standard-webhooks/internal.lua

Co-authored-by: Samuele <samuele@konghq.com>

---------

Co-authored-by: Samuele <samuele@konghq.com>
(cherry picked from commit 03f056c)

* fix: cherry pick

* Update plugins-add-standard-webhooks.yml

* Update plugins-add-standard-webhooks.yml

* Update kong/plugins/standard-webhooks/handler.lua

Co-authored-by: Samuele <samuele@konghq.com>

* fix order

---------

Co-authored-by: Samuele <samuele@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed schema-change-noteworthy size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants