Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(emmy-lua-debugger): add support status warning for feature #12966

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix(emmy-lua-debugger): add support status warning for feature #12966

merged 1 commit into from
Apr 30, 2024

Conversation

hanshuebner
Copy link
Contributor

Summary

Add a warning to point out that the EmmyLua debugger integration is not supported at this point.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4404

@hanshuebner hanshuebner added skip-changelog cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Apr 30, 2024
dndx
dndx requested changes Apr 30, 2024
View reviewed changes
Copy link
Member

@dndx dndx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the changelog as well? That will solve the issue on the EE side as well.

@hanshuebner hanshuebner force-pushed the fix/emmy-debugger-unsupported-warning branch from ae62489 to b4b261e Compare April 30, 2024 09:03
@hanshuebner hanshuebner requested a review from dndx April 30, 2024 09:03
@hanshuebner hanshuebner merged commit 410298b into master Apr 30, 2024
25 checks passed
@hanshuebner hanshuebner deleted the fix/emmy-debugger-unsupported-warning branch April 30, 2024 09:30
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@hanshuebner hanshuebner mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dndx dndx dndx approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@hanshuebner hanshuebner

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanshuebner @team-gateway-bot @dndx @ADD-SP