Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugins/grpc-gateway):handle json decode error safely(#10028) #12971

Merged
merged 5 commits into from
May 2, 2024
Merged

fix(plugins/grpc-gateway):handle json decode error safely(#10028) #12971

merged 5 commits into from
May 2, 2024

Conversation

beardnick
Copy link
Contributor

@beardnick beardnick commented May 1, 2024 •
edited
Loading

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #10028

@CLAassistant
Copy link

CLAassistant commented May 1, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added plugins/grpc-gateway cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels May 1, 2024
@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label May 1, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 1, 2024
@beardnick
Copy link
Contributor Author

updated. PTAL @oowl

@beardnick @hanshuebner
Update changelog/unreleased/kong/fix-grpc-gateway-json-decode-bug.yml
779d8d6 
Co-authored-by: Hans Hübner <hans.huebner@gmail.com>
@beardnick beardnick requested a review from hanshuebner May 2, 2024 04:13
@hanshuebner hanshuebner merged commit 66e9b88 into Kong:master May 2, 2024
25 checks passed
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@hanshuebner
Copy link
Contributor

Merged, thank you for your contribution!

@beardnick
Copy link
Contributor Author

Merged, thank you for your contribution!

Thank you for your help and patience again.

@kikito
Copy link
Member

kikito commented May 7, 2024

@beardnick Notice that this fix will land in 3.8, as it was merged after 3.7 Feature Freeze and we don't have bandwidth to backport it in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshuebner hanshuebner hanshuebner approved these changes

@oowl oowl oowl approved these changes

Assignees
No one assigned
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/grpc-gateway size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect status code 500 for invalid JSON data processed by grpc-gateway plugin
7 participants
@beardnick @CLAassistant @team-gateway-bot @hanshuebner @kikito @oowl @team-eng-enablement