feat(deps): add ada - whatwg-compliant and fast url parser #13120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
github-actions
bot
added
build/bazel
cherry-pick kong-ee
bungle
force-pushed
the
feat/add-ada
branch
4 times, most recently
from
92ef68e
to
8caa55e
Compare
bungle
changed the title
bungle
force-pushed
the
feat/add-ada
branch
2 times, most recently
from
07fee35
to
05c6ac8
Compare
bungle
force-pushed
the
feat/add-ada
branch
2 times, most recently
from
f0badcb
to
822ebcb
Compare
gszr
approved these changes
Jun 5, 2024
|
Verified locally as well. |
bungle
force-pushed
the
feat/add-ada
branch
2 times, most recently
from
f521478
to
fcb7f76
Compare
team-eng-enablement
added
author/community
bungle
force-pushed
the
feat/add-ada
branch
4 times, most recently
from
89158c9
to
4b5e68a
Compare
### Summary Adds libada and lua-resty-ada as a dependency. This is needed for: #12758 But it may be great for many other uses too. The `lua-resty-ada` LuaJIT FFI bindings can be found here: https://github.com/bungle/lua-resty-ada Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
samugi
approved these changes
Sep 3, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13120-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13120-to-master-to-upstream
git checkout -b cherry-pick-13120-to-master-to-upstream
ancref=$(git merge-base 4e38b965b922f57febe8652fb96b7d74aeab591a e6781af2891155f7d4abeb47dfda5864534ce28a)
git cherry-pick -x $ancref..e6781af2891155f7d4abeb47dfda5864534ce28a |
github-actions
bot
added
the
incomplete-cherry-pick
|
The EE cherry is here: |
bungle
removed
the
incomplete-cherry-pick
andrewgkew
pushed a commit
to andrewgkew/kong
that referenced
this pull request
Sep 5, 2024
### Summary Adds libada and lua-resty-ada as a dependency. This is needed for: Kong#12758 But it may be great for many other uses too. The `lua-resty-ada` LuaJIT FFI bindings can be found here: https://github.com/bungle/lua-resty-ada Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
curiositycasualty
pushed a commit
that referenced
this pull request
Oct 15, 2024
Adds libada and lua-resty-ada as a dependency. This is needed for: #12758 But it may be great for many other uses too. The `lua-resty-ada` LuaJIT FFI bindings can be found here: https://github.com/bungle/lua-resty-ada Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds libada as a dependency.
This is needed for:
#12758
But it may be great for many other uses too.
The
lua-resty-adaLuaJIT FFI bindings can be found here: https://github.com/bungle/lua-resty-ada (and will be included as separate PR).KAG-5106