fix(cmd): fix kong cli not printing some debug level error log #13143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
ADD-SP
approved these changes
Jun 4, 2024
ADD-SP
requested changes
Jun 4, 2024
windmgc
force-pushed
the
fix-cli-cmd-not-printing-debug-msg
branch
from
638f701
to
976d3a0
Compare
3 tasks
… caused by insufficient buffer size (#13163)
windmgc
force-pushed
the
fix-cli-cmd-not-printing-debug-msg
branch
from
713f6e7
to
53a5d80
Compare
ADD-SP
approved these changes
Jun 5, 2024
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a problem that running
kongCLI command will not print some of the debug level error logs. Those error logs may be triggered byngx.logbefore the actualkong.cmdmodule gets called.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
The issue in this PR was discovered when debugging FTI-5995, but it is not related to the ticket's problem at all.