feat(queue): implement functions Quque.is_full & Queue.can_enqueue
#13164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
ADD-SP
changed the title
Quque.is_full(queue_conf, entry) to check the state before enqueuingQuque.is_full(queue_conf, entry) to check the state before enqueueing
ADD-SP
force-pushed
the
add_sp/feat-plugin-queue-is-full
branch
2 times, most recently
from
4e1dafe
to
43516ac
Compare
ADD-SP
changed the title
Quque.is_full(queue_conf, entry) to check the state before enqueueingQuque.is_full & Queue.will_full
ADD-SP
changed the title
Quque.is_full & Queue.will_fullQuque.is_full & Queue.will_full
ADD-SP
force-pushed
the
add_sp/feat-plugin-queue-is-full
branch
2 times, most recently
from
09ef243
to
f265514
Compare
hanshuebner
suggested changes
Jun 5, 2024
ADD-SP
force-pushed
the
add_sp/feat-plugin-queue-is-full
branch
from
f265514
to
04f7f26
Compare
ADD-SP
changed the title
Quque.is_full & Queue.will_fullQuque.is_full & Queue.can_enqueue
hanshuebner
reviewed
Jun 5, 2024
hanshuebner
approved these changes
Jun 5, 2024
chronolaw
reviewed
Jun 6, 2024
hanshuebner
reviewed
Jun 6, 2024
Generating entries is expensive in some cases, so we'd better have a way to observe state of the Queue.
…_full` Co-authored-by: Hans Hübner <hans.huebner@gmail.com>
…_full` Co-authored-by: Hans Hübner <hans.huebner@gmail.com>
…_full` Co-authored-by: Chrono <chrono_cpp@me.com>
ADD-SP
force-pushed
the
add_sp/feat-plugin-queue-is-full
branch
from
fd77e80
to
ae0d501
Compare
…_full` Co-authored-by: Hans Hübner <hans.huebner@gmail.com>
chronolaw
reviewed
Jun 6, 2024
chronolaw
reviewed
Jun 7, 2024
chronolaw
approved these changes
Jun 7, 2024
|
Successfully created cherry-pick PR for |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQUASH AND MERGE
Summary
Generating entries is expensive in some cases,
so we'd better have a way to observe the state of the Queue.
So we are able to skip generating if the Queue is already or will be full.
This is the pre-requirement of https://github.com/Kong/kong-ee/pull/9273.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4270