refactor(tools/http): simplify check_https() with ngx.var #13167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
chronolaw
force-pushed
the
refactor/simplify_check_https_func
branch
from
3b19be9
to
13af01e
Compare
chronolaw
force-pushed
the
refactor/simplify_check_https_func
branch
from
13af01e
to
bfae91c
Compare
Water-Melon
approved these changes
Jun 7, 2024
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We used to call
ngx.req.get_headers()to get all possible header values,but since nginx 1.23.0 or OpenResty 1.25.3.1
ngx.varcan get a combined value for all header valueswith identical name (joined by comma), so I think that we could simplify these code.
There is one concern:
If header
X-Forwarded-Protohas a comma separated value likehttp, https,This PR will think it is a multiple header request and report an error
Only one X-Forwarded-Proto header allowed.But I think that it is an unlikely case in the real world.
KAG-4673
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]