-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pdk): implement private PDK functions to process rate_limiting response headers #13181
feat(pdk): implement private PDK functions to process rate_limiting response headers #13181
Conversation
eb483b8
to
2a51106
Compare
f78588b
to
eff85a9
Compare
37ae038
to
28e620b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need unit test coverage for this given it's an addition to the PDK?
28e620b
to
950fe13
Compare
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would do it with busted. But it's fine
…using private PDK functions
…cessing using private PDK functions
950fe13
to
1808c0c
Compare
REBASE AND MERGE
Summary
Currently, all rate-limiting-like plugins process their own response headers individually, we should unify this process by a private PDK function.
This PR is also for KAG-4679.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4679