Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(tools/emmy_debugger): prefer vararg-style for ngx.log #13185

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jun 7, 2024

Summary

We prefer vararg-style calls for ngx.log.
KAG-4673
See:https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#strings

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jun 7, 2024
@flrgh flrgh merged commit 49f7b44 into master Jun 10, 2024
41 checks passed
@flrgh flrgh deleted the style/vararg_style_for_ngx_log branch June 10, 2024 18:39
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants