refactor(*): use kong.tools.string whenever possible #13188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/cli
plugins/oauth2
core/clustering
plugins/aws-lambda
plugins/response-transformer
core/db
plugins/request-size-limiting
plugins/response-ratelimiting
core/configuration
cherry-pick kong-ee
bungle
force-pushed
the
refactor/speed-up-strip-everywhere
branch
from
b5bdfbb
to
3b3f6e2
Compare
### Summary `kong.tools.string` has a faster implementation of e.g. `strip`. This makes our code use the `kong.tools.string` whenever possible and removes `pl.stringx` usage in those cases. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
force-pushed
the
refactor/speed-up-strip-everywhere
branch
from
3b3f6e2
to
fec35cf
Compare
jschmid1
approved these changes
Jun 12, 2024
samugi
approved these changes
Jun 12, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13188-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13188-to-master-to-upstream
git checkout -b cherry-pick-13188-to-master-to-upstream
ancref=$(git merge-base 5c34759a96b82b54a81b8d6ffec6ce60ded15cc6 fec35cfccbdf780a3ec2203ed580fa80f1a20020)
git cherry-pick -x $ancref..fec35cfccbdf780a3ec2203ed580fa80f1a20020 |
github-actions
bot
added
the
incomplete-cherry-pick
bungle
removed
the
incomplete-cherry-pick
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
`kong.tools.string` has a faster implementation of e.g. `strip`. This makes our code use the `kong.tools.string` whenever possible and removes `pl.stringx` usage in those cases. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
kong.tools.stringhas a faster implementation of e.g.strip. This makes our code usethe
kong.tools.stringwhenever possible and removespl.stringxusage in those cases.This is a follow-up PR to:
#13168
KAG-4684