Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(pdk): get hostname with string.strip #13208

Closed
wants to merge 1 commit into from
Closed

style(pdk): get hostname with string.strip #13208

wants to merge 1 commit into from

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jun 14, 2024 •
edited
Loading

Summary

tools.string.strip() has better performance than gsub, and it is easy to understand.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/pdk cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jun 14, 2024
@chronolaw chronolaw marked this pull request as draft June 14, 2024 03:43
@chronolaw chronolaw closed this Jun 14, 2024
@chronolaw chronolaw deleted the style/string_strip_for_hostname branch June 14, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/pdk size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chronolaw