fix(core): fix ngx.balancer.recreate_request does not refresh body bu… #13377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build/bazel
cherry-pick kong-ee
windmgc
approved these changes
Jul 17, 2024
|
Need a change log entry? |
chronolaw
reviewed
Jul 24, 2024
changelog/unreleased/kong/fix-ngx-balancer-recreate-request-api-for-balancer-body-refresh.yml
Outdated
Show resolved
Hide resolved
oowl
force-pushed
the
fix/recreate-request-work-for-body-patch
branch
from
dd8494e
to
241ce9d
Compare
fffonion
approved these changes
Jul 24, 2024
|
hold merge after 3.8 is released for safety of summit |
|
converting this to draft because there's no |
chronolaw
approved these changes
Jul 24, 2024
chobits
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
The bugfix patch is referenced from nginx correct logic for setting upstream body bufs: https://github.com/nginx/nginx/blob/master/src/http/ngx_http_upstream.c#L631
…ffer issue when ngx.req.set_body_data is used in balancer phase
fffonion
force-pushed
the
fix/recreate-request-work-for-body-patch
branch
from
241ce9d
to
0660ae9
Compare
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ffer issue when ngx.req.set_body_data is used in balancer phase
backport Openresty upstream fix: openresty/lua-nginx-module#2334
issues context: openresty/lua-nginx-module#2333
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
AG-12