Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(proxy-cache): changes age param" #13386

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Revert "fix(proxy-cache): changes age param" #13386

merged 1 commit into from
Jul 23, 2024

Conversation

jschmid1
Copy link
Contributor

Reverts #12812

@jschmid1 jschmid1 requested a review from a team July 18, 2024 09:14
@chronolaw
Copy link
Contributor

Could I get the explain for this revert?

@jschmid1
Copy link
Contributor Author

Could I get the explain for this revert?

we can get away without a schema change to get the desired behavior. see #13387

@jschmid1 jschmid1 merged commit 4c772c6 into master Jul 23, 2024
27 checks passed
@jschmid1 jschmid1 deleted the revert-12812-master branch July 23, 2024 09:08
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13386-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13386-to-master-to-upstream
git checkout -b cherry-pick-13386-to-master-to-upstream
ancref=$(git merge-base 44ecc323ba7f01afe66017c6c9fdcf17ac0fe2d9 5eac36bb5d2a80670e4e7527f3ea986cf87f6a86)
git cherry-pick -x $ancref..5eac36bb5d2a80670e4e7527f3ea986cf87f6a86

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jul 23, 2024
@jschmid1 jschmid1 removed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshuebner hanshuebner hanshuebner approved these changes

@samugi samugi samugi approved these changes

@nowNick nowNick nowNick approved these changes

@kikito kikito Awaiting requested review from kikito

Assignees

@jschmid1 jschmid1

Labels
core/clustering plugins/proxy-cache schema-change-noteworthy size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jschmid1 @chronolaw @team-gateway-bot @hanshuebner @samugi @nowNick