Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dns): support resolver_* directives for new dns client #13427

Merged
merged 18 commits into from
Aug 8, 2024
Merged

feat(dns): support resolver_* directives for new dns client #13427

merged 18 commits into from
Aug 8, 2024

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Jul 26, 2024 •
edited
Loading

Summary

The new DNS implementation requires introducing a new set of directives because some directives (resolver_xxx) behave differently between the old and new libraries. Without clear differentiation, users might be confused by the inconsistent behavior of these directives in the new library.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-4994

@chobits chobits marked this pull request as draft July 26, 2024 08:28
@github-actions github-actions bot added core/templates cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jul 26, 2024
@chobits chobits marked this pull request as ready for review July 29, 2024 23:57
@chronolaw

This comment was marked as resolved.

Sign in to view
@chronolaw chronolaw self-requested a review July 31, 2024 03:19
@chronolaw
Copy link
Contributor

I think that we also need a change log entry to describe these directives.

@chobits
Copy link
Contributor Author

chobits commented Jul 31, 2024

Should we modify conf_loader/constants.lua for these new options?

Thanks, I have already fixed in new commit.

@chobits chobits requested a review from ADD-SP July 31, 2024 07:09
chronolaw
chronolaw reviewed Jul 31, 2024
View reviewed changes
kong/tools/dns.lua Outdated Show resolved Hide resolved
@chobits chobits force-pushed the fix/new_dns_directives branch 3 times, most recently from 962ee49 to 3ce977d Compare August 5, 2024 06:04
fffonion
fffonion reviewed Aug 5, 2024
View reviewed changes
kong.conf.default Outdated Show resolved Hide resolved
@chobits chobits force-pushed the fix/new_dns_directives branch 2 times, most recently from ba7ffe6 to 58efdc4 Compare August 7, 2024 02:11
@outsinre outsinre self-requested a review August 7, 2024 08:06
@chobits chobits mentioned this pull request Aug 8, 2024
Merged
3 tasks
dndx
dndx reviewed Aug 8, 2024
View reviewed changes
kong.conf.default Show resolved Hide resolved
dndx
dndx reviewed Aug 8, 2024
View reviewed changes
kong.conf.default Outdated Show resolved Hide resolved
@chobits
feat(dns): introduce new directives resolver_xxx for new dns client
a8decc1
@chobits
adds constants to conf_loader/contants.lua
a281b9c
@chobits
fix changelog
f12b9ec
@chobits
fixed bug where conf.legacy_dns_client is wrongly compared to "off"
a700c7f
@chobits
use share dict kong_dns_cache to check if new dns is enabled
4aa768e
@chobits
added tests cases
f1299b9
@chobits
fix wasm case error
408d433
@chobits
fix typo
8530818
@chobits
added resolver_hostsfile to test cases
cac6378
@chobits
added resolver_hostsfile to test cases (2)
8d058ae
@chobits
added resolver_hostsfile to test cases (3)
8460f86
@chobits
modified changelog
2dd40bb
@chobits
update directive from resolver_hostsfile to resolver_hosts_file
1e18f3f
@chobits
update directive from resolver_hostsfile to resolver_hosts_file (kong…
e003c8f 
….conf)
@chobits
modify the default value of resolver_family to A,SRv
072b6bb
@chobits
add example for resolver_address directive
bb6ccac
@chobits
add example for resolver_address directive (2)
e9bf009
@chobits
fixed default value of resolver_address and resolver_valid_ttl
cccb242
@dndx dndx merged commit 0f73339 into master Aug 8, 2024
25 checks passed
@dndx dndx deleted the fix/new_dns_directives branch August 8, 2024 09:23
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyZhang0707 AndyZhang0707 AndyZhang0707 left review comments

@fffonion fffonion fffonion left review comments

@chronolaw chronolaw chronolaw left review comments

@dndx dndx dndx approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

@liverpool8056 liverpool8056 liverpool8056 approved these changes

@outsinre outsinre Awaiting requested review from outsinre

Assignees

@chobits chobits

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/configuration core/templates size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@chobits @chronolaw @team-gateway-bot @dndx @AndyZhang0707 @fffonion @ADD-SP @liverpool8056