fix(vault): apply secret rotation error log throttling #13449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/pdk
cherry-pick kong-ee
outsinre
reviewed
Aug 13, 2024
| if not ok then | ||
| self.log.warn(err) | ||
| -- throttling the error logging for secrets rotation | ||
| local add_ok, _ = SECRETS_CACHE:add(error_logging_flag_key, true) |
There was a problem hiding this comment.
LGTM.
Is it worth using cache to decrease num of log entries?
team-eng-enablement
added
author/community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a simpler alternative solution for #13194. Apply error log throttling on the error logs that happened during secret rotation. Each secret will only log its error once during the period that it fails to rotate the value.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-5775