Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(request-debugging): Finer time resolution and latency in total #13460

Conversation

Oyami-Srk
Copy link
Member

@Oyami-Srk Oyami-Srk commented Aug 6, 2024

Summary

Using time_ns to measure the context duration and make total_time finer resolution when less than 1ms.

A field called total_time_without_upsteam is introduced to represent total latency without upstream.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4733
FTI-5989

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Aug 6, 2024
@Oyami-Srk Oyami-Srk force-pushed the haoxuan/KAG-4733-request-debugger-finer-resolution-and-total-latency branch 2 times, most recently from ea857b6 to 36603ae Compare August 12, 2024 07:19
@Oyami-Srk Oyami-Srk marked this pull request as ready for review August 12, 2024 07:19
@Oyami-Srk Oyami-Srk force-pushed the haoxuan/KAG-4733-request-debugger-finer-resolution-and-total-latency branch from 36603ae to 3343c09 Compare August 12, 2024 07:21
@Oyami-Srk Oyami-Srk force-pushed the haoxuan/KAG-4733-request-debugger-finer-resolution-and-total-latency branch from 3343c09 to 8c4c32a Compare August 12, 2024 09:47
@team-eng-enablement team-eng-enablement added author/community PRs from the open-source community (not Kong Inc) and removed author/community PRs from the open-source community (not Kong Inc) labels Aug 13, 2024
@Oyami-Srk Oyami-Srk force-pushed the haoxuan/KAG-4733-request-debugger-finer-resolution-and-total-latency branch from 8c4c32a to d5e56ff Compare August 14, 2024 02:41
kong/timing/context.lua Outdated Show resolved Hide resolved
@team-eng-enablement team-eng-enablement added author/community PRs from the open-source community (not Kong Inc) and removed author/community PRs from the open-source community (not Kong Inc) labels Aug 14, 2024
@Oyami-Srk Oyami-Srk force-pushed the haoxuan/KAG-4733-request-debugger-finer-resolution-and-total-latency branch from d5e56ff to 80167f2 Compare August 14, 2024 09:19
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 18, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 18, 2024
Using `time_ns` to measure the context duration and introduced a field
`total_time_without_upstream` to represent total latency without upstream.

KAG-4733
@Oyami-Srk Oyami-Srk force-pushed the haoxuan/KAG-4733-request-debugger-finer-resolution-and-total-latency branch from 69d08e2 to da73b5e Compare September 19, 2024 01:47
@team-gateway-bot team-gateway-bot removed the author/community PRs from the open-source community (not Kong Inc) label Sep 20, 2024
@Oyami-Srk Oyami-Srk force-pushed the haoxuan/KAG-4733-request-debugger-finer-resolution-and-total-latency branch from 0e08253 to 4b4acd2 Compare September 23, 2024 07:28
@Oyami-Srk Oyami-Srk removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Oct 10, 2024
@ADD-SP ADD-SP merged commit ad758d7 into master Oct 11, 2024
29 checks passed
@ADD-SP ADD-SP deleted the haoxuan/KAG-4733-request-debugger-finer-resolution-and-total-latency branch October 11, 2024 03:33
@kikito kikito added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Nov 4, 2024
@kikito
Copy link
Member

kikito commented Nov 4, 2024

cherrypick ee in https://github.com/Kong/kong-ee/pull/10279

@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13460-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13460-to-master-to-upstream
git checkout -b cherry-pick-13460-to-master-to-upstream
ancref=$(git merge-base 331194f4a6553ac3017035bf2d5aecc3ade4e024 4b4acd224a9ff9c2b4704cf0b3d465eee0eb72c2)
git cherry-pick -x $ancref..4b4acd224a9ff9c2b4704cf0b3d465eee0eb72c2

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants