chore(ci): deck integration tests fail CI on test failure

[samugi]

Summary

when deck integration tests fail, a request for changes was created in the PR. This was often ignored: let's fail CI instead.

Checklist

• The Pull Request has tests
• A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
• There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-5058

dismiss

[team-gateway-bot]

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13475-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13475-to-master-to-upstream
git checkout -b cherry-pick-13475-to-master-to-upstream
ancref=$(git merge-base e61c4dd77d64d75b91f5dd03c17ffe55586bbdaa 97c42fea45b0104891184b32a54900bb29b6a37e)
git cherry-pick -x $ancref..97c42fea45b0104891184b32a54900bb29b6a37e

[samugi]

/prdiff #13606

[github-actions]

📝 Diff from #13606

Click to expand

--- /dev/fd/63	2024-09-06 14:25:00.557064487 +0000
+++ /dev/fd/62	2024-09-06 14:25:00.557064487 +0000
@@ -0,0 +1,38 @@
+--- a/.github/workflows/deck-integration.yml    # [PR: 13475]
++++ b/.github/workflows/deck-integration.yml    # [PR: 13475]
+-        continue-on-error: true
+-
+-      - name: Find review if exists
+-        id: find-review
+-        uses: actions/github-script@v7
+-        with:
+-          result-encoding: json
+-          retries: 3
+-          script: |
+-            const reviews = await github.paginate(github.rest.pulls.listReviews, {
+-              owner: context.repo.owner,
+-              repo: context.repo.repo,
+-              pull_number: context.issue.number,
+-            });
+-
+-            const botReview = reviews.reverse().find(review => {
+-              return review.user.login === "github-actions[bot]" && review.body.includes("decK integration tests");
+-            });
+-
+-            if (botReview && botReview.state === "CHANGES_REQUESTED") {
+-              return { "review_id": botReview.id };
+-            } else {
+-              return { "review_id": "" };
+-            }
+-
+-      - name: Request changes if failures are detected
+-        if: ${{ fromJson(steps.find-review.outputs.result).review_id == '' && steps.deck_tests.outcome != 'success' }}
+-        uses: actions/github-script@v7
+-        with:
+-          script: |
+-            github.rest.pulls.createReview({
+-              owner: context.repo.owner,
+-              repo: context.repo.repo,
+-              pull_number: context.issue.number,
+-              event: 'REQUEST_CHANGES',
+-              body: `## decK integration tests
@@ -1,0 +40,2 @@
+:warning: failure detected. Please check [the workflow logs](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}) for more details.`
+-            })