Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gha): Set default timeouts. #13476

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

curiositycasualty
Copy link
Contributor

@curiositycasualty curiositycasualty commented Aug 8, 2024

Summary

These changes set a default-timeout for all the workflows present at time of writing.
To compliment these changes, I have also set an override of the org-wide var.GHA_DEFAULT_TIMEOUT (10 minutes at the org level) to 30 minutes for both the CE and EE repos.

This PR replaces #12566 which was aggregating auto-generated commits, some of which introduced syntactical issues and caused the workflows to be invalid/broken. To the best of my ability, these changes do not do that and represent valid workflows.

Checklist

  • [na] The Pull Request has tests
  • [na] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [na] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Aug 8, 2024
Copy link
Contributor

@outsinre outsinre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this works, is there any way to set a global default? Then, we do not need to insert the timeout directive to each job?

Say, a new workflow may be added but the author forgot to set it.

@team-eng-enablement team-eng-enablement added author/community PRs from the open-source community (not Kong Inc) and removed author/community PRs from the open-source community (not Kong Inc) labels Aug 13, 2024
@curiositycasualty
Copy link
Contributor Author

While this works, is there any way to set a global default? Then, we do not need to insert the timeout directive to each job?

Say, a new workflow may be added but the author forgot to set it.

Sadly no. There is no way to set a default timeout at the org or account level. The only way to accomplish this is by the method employed here; an org-level variable plus the addition of the line to all affected workflows :(

@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) chore Not part of the core functionality of kong, but still needed size/M skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants