-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(llm): add auth.allow_override option for llm auth functionality #13493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No test?
Seems if this vale is true, means auth info from the request is used, and ignore configured auth?
e75da00
to
33fca9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would name it "override_request_auth
" as we are overriding the request. But anyway LGTM.
aa57979
to
22f697b
Compare
The failing test seems relevant |
22f697b
to
359b486
Compare
I think this works fine! But 1 failing test with random 500. |
359b486
to
a2dc1df
Compare
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13493-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13493-to-master-to-upstream
git checkout -b cherry-pick-13493-to-master-to-upstream
ancref=$(git merge-base 9bc3deb30041dbc45b1fe44fe8069f21ab69caaa 1b9314d6cd28e2fca660f3db625619b9f6032e5e)
git cherry-pick -x $ancref..1b9314d6cd28e2fca660f3db625619b9f6032e5e |
…13493) Add `allow_override` option to allow overriding the upstream model auth parameter or header from the caller's request.
Summary
Add
allow_override
option to allow overriding the upstream model auth parameter or header from the caller's request.Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
/AG-92