fix(vault): reference ending with slash when parsed should not return a key #13504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/pdk
cherry-pick kong-ee
bungle
force-pushed
the
fix/vault-reference-endslash
branch
from
fd53ac8
to
bd614d1
Compare
bungle
changed the title
bungle
changed the title
bungle
force-pushed
the
fix/vault-reference-endslash
branch
from
bd614d1
to
a222cf2
Compare
bungle
force-pushed
the
fix/vault-reference-endslash
branch
2 times, most recently
from
2f9e567
to
e702139
Compare
… a key ### Summary Our docs state here: https://docs.konghq.com/gateway/latest/kong-enterprise/secrets-management/reference-format/#secret-key > If secret key ends with /, then it is not considered as a Secret Key but as a part of Secret Id. > The difference between Secret Key and Secret Id is that only the Secret Id is sent to vault API, > and the Secret Key is only used when processing The logic was not working correctly because it was incorrectly assuming what `require("socket.url").parse_path` did, that is: ```lua parse_path("/a") -- { "a", is_absolute = 1 } ``` ```lua parse_path("/a/") -- { "a", is_absolute = 1, is_directory = 1 } ``` ```lua parse_path("/a/b") -- { "a", "b", is_absolute = 1 } ``` ```lua > parse_path("/a/b/") -- { "a", "b", is_absolute = 1, is_directory = 1} ``` This fixes it. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
### Summary Less pressure to garbage collector. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
force-pushed
the
fix/vault-reference-endslash
branch
from
e702139
to
f1859d7
Compare
jschmid1
approved these changes
Aug 21, 2024
samugi
approved these changes
Aug 21, 2024
3 tasks
|
Successfully created backport PR for |
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our docs state here:
https://docs.konghq.com/gateway/latest/kong-enterprise/secrets-management/reference-format/#secret-key
The logic was not working correctly because it was incorrectly assuming what
require("socket.url").parse_pathdid, that is:This fixes it.
KAG-5181
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.md