fix(ai-proxy): disable gzip for SSE streams #13506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cherry-pick kong-ee
oowl
approved these changes
Aug 16, 2024
chronolaw
approved these changes
Aug 19, 2024
StarlightIbuki
approved these changes
Aug 19, 2024
| else | ||
| kong.response.clear_header("Content-Encoding") | ||
|
|
||
| if accept_gzip() then |
There was a problem hiding this comment.
or use elseif here?
There was a problem hiding this comment.
That would be slightly not equivalent to what's happening here. The last "else" would always happen. Instead it seems we only want kong.response.clear_header("Content-Encoding") to happen if llm_state.is_streaming_mode() is false (and not when it is non-falsy but accept_gzip is true)
liverpool8056
approved these changes
Aug 19, 2024
|
Successfully created cherry-pick PR for |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #13155