perf(plugins-iterator): remove unneeded tail-calls and optimize lookup_cfg #13511
+29
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/proxy
cherry-pick kong-ee
bungle
force-pushed
the
perf/plugin-iterator-lookup-cfg
branch
from
d8fb9dc
to
7c0e293
Compare
| @@ -82,7 +81,7 @@ local PluginsIterator = {} | |||
| -- @tparam string|nil consumer_id The consumer identifier. If `nil`, an empty string is used. | |||
| -- @treturn string The compound key, in the format `route_id:service_id:consumer_id`. | |||
| local function build_compound_key(route_id, service_id, consumer_id) | |||
There was a problem hiding this comment.
Just trying to understand the code and new to Lua.
Is there any reason to keep this function if we are not using it and the scope is local as well ?
There was a problem hiding this comment.
@SauravPrakash98 it is used during building new plugin iterator, just not used on request time.
bungle
force-pushed
the
perf/plugin-iterator-lookup-cfg
branch
from
7c0e293
to
6dee3bb
Compare
…p_cfg ### Summary This might create less garbage and generate better JIT code. It would be nice to test if this has any difference in Kong benchmarks. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
force-pushed
the
perf/plugin-iterator-lookup-cfg
branch
from
6dee3bb
to
dd56daf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This might create less garbage and generate better JIT code.
It would be nice to test if this has any difference in Kong benchmarks.