Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ai-transformers): fix compat with LT 3.8.0 #13556

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix(ai-transformers): fix compat with LT 3.8.0 #13556

merged 1 commit into from
Aug 23, 2024

Conversation

tysoekong
Copy link
Contributor

@tysoekong tysoekong commented Aug 22, 2024 •
edited by jira bot
Loading

Summary

Fixes KAG-5232

Checklist

Issue reference

KAG-5232

@tysoekong tysoekong added skip-changelog cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee backport release/3.7.x labels Aug 22, 2024
ADD-SP
ADD-SP reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@ADD-SP ADD-SP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a compatibility test to spec/02-integration/09-hybrid_mode/09-config-compat_spec.lua?

@AndyZhang0707 AndyZhang0707 added this to the 3.8.0 milestone Aug 23, 2024
@tysoekong
Copy link
Contributor Author

@ADD-SP There... is one

@tysoekong
Copy link
Contributor Author

tysoekong commented Aug 23, 2024 •
edited
Loading

@ADD-SP Sorry I get the comment now. It is actually the same test as previously added during development, you see. I just add this OTHER new field into the same test :)

@samugi samugi merged commit 846f222 into master Aug 23, 2024
58 checks passed
@samugi samugi deleted the fix/ai_compat branch August 23, 2024 15:48
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@team-gateway-bot team-gateway-bot mentioned this pull request Aug 23, 2024
Merged
3 tasks
@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.8.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP left review comments

@samugi samugi samugi approved these changes

@nowNick nowNick nowNick approved these changes

@AndyZhang0707 AndyZhang0707 Awaiting requested review from AndyZhang0707

@fffonion fffonion Awaiting requested review from fffonion

@flrgh flrgh Awaiting requested review from flrgh

@oowl oowl Awaiting requested review from oowl

@liverpool8056 liverpool8056 Awaiting requested review from liverpool8056

Assignees

@tysoekong tysoekong

Labels
backport release/3.8.x cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/S skip-changelog
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tysoekong @team-gateway-bot @samugi @nowNick @ADD-SP @AndyZhang0707