fix(core): rename unix sockets to shorter names to avoid exceeding socket name limit #13557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/proxy
core/clustering
core/templates
core/configuration
cherry-pick kong-ee
brentos
force-pushed
the
fix/kag-5136-shorten-unix-domain-sockets
branch
from
765e918
to
1d56fdb
Compare
…cket name limit Unix domain sockets have a hard length limit of around 108 characters. When Kong is configured in a deeply nested directory structure, this can cause Kong to fail to start. Reducing the file name length will help alleviate this issue. Fix: KAG-5136
brentos
force-pushed
the
fix/kag-5136-shorten-unix-domain-sockets
branch
from
1d56fdb
to
5ab75a8
Compare
locao
requested changes
Aug 23, 2024
There was a problem hiding this comment.
IIRC this is a fix for an unreleased feature, right? A changelog entry is not needed in such cases.
There was a problem hiding this comment.
Yes and no? It is still a possible problem even before the unreleased fix. The new feature just makes it more likely to happen, since the path to the sockets has become longer by adding the subdirectory /sockets/
flrgh
reviewed
Aug 23, 2024
flrgh
reviewed
Aug 23, 2024
flrgh
reviewed
Aug 23, 2024
| @@ -83,7 +83,7 @@ stream { | |||
|
|
|||
| > if cluster_ssl_tunnel then | |||
| server { | |||
| listen unix:${{SOCKET_PATH}}/cluster_proxy_ssl_terminator.sock; | |||
| listen unix:${{SOCKET_PATH}}/${{CLUSTER_PROXY_SSL_TERMINATOR_SOCK}}; | |||
There was a problem hiding this comment.
The fact that these are no longer hard-coded strings ❤️
chronolaw
reviewed
Aug 24, 2024
locao
approved these changes
Aug 26, 2024
|
Successfully created backport PR for |
|
Successfully created cherry-pick PR for |
curiositycasualty
pushed a commit
that referenced
this pull request
Oct 15, 2024
…cket name limit (#10114) * fix(core): rename unix sockets to shorter names to avoid exceeding socket name limit (#13557) (cherry picked from commit 2dc36f2) * Renamed kong_debug socket to shorter name * update changelog, add kong_debug socket to ee_constants, update test * use pairs instead of ipairs --------- Co-authored-by: Brent Yarger <brent.yarger@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unix domain sockets have a hard length limit of around 108 characters. When Kong is configured in a deeply nested directory structure, this can cause Kong to fail to start. Reducing the file name length will help alleviate this issue.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix: KAG-5136