tests(ai-plugins): fix flaky latency assertion (part 2) #13560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
oowl
reviewed
Aug 23, 2024
| @@ -1444,7 +1444,7 @@ for _, strategy in helpers.all_strategies() do if strategy ~= "cassandra" then | |||
| first_got.usage.time_per_token = 1 | |||
|
|
|||
| assert.same(first_expected, first_got) | |||
| assert.is_true(actual_llm_latency > 0) | |||
| assert.is_true(actual_llm_latency >= 0) | |||
There was a problem hiding this comment.
Yes. This latency is calculated with ngx.now() and not any monotonic time source, so it's always possible for it to be 0, especially in tests where things are mocked/no actual proxying happens.
kong/kong/llm/drivers/shared.lua
Line 660 in 846f222
kong/kong/llm/drivers/shared.lua
Line 718 in 846f222
Applies the same fix as 58c580f to similar tests.
flrgh
force-pushed
the
tests/ai-plugin-latency
branch
from
5291569
to
b70c138
Compare
brentos
approved these changes
Aug 23, 2024
Hayk-S
approved these changes
Aug 23, 2024
|
Successfully created backport PR for |
|
Successfully created cherry-pick PR for |
flrgh
added a commit
that referenced
this pull request
Aug 23, 2024
curiositycasualty
pushed a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the same fix as 58c580f (#13558) to similar tests.
KAG-5251