-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ai): caching use deep copy for request table #13566
Merged
kikito
merged 4 commits into
master
from
featai-caching-use-deep-copy-for-request-table
Aug 26, 2024
Merged
feat(ai): caching use deep copy for request table #13566
kikito
merged 4 commits into
master
from
featai-caching-use-deep-copy-for-request-table
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
plugins/ai-proxy
plugins/ai-request-transformer
plugins/ai-response-transformer
labels
Aug 23, 2024
Please make the appropriate changes to get this PR in shape for merge:
|
flrgh
requested review from
liverpool8056
and removed request for
liverpool8056
August 23, 2024 18:42
AntoineJac
changed the title
Update handler.lua
feat(ai): caching use deep copy for request table
Aug 26, 2024
bungle
approved these changes
Aug 26, 2024
kikito
approved these changes
Aug 26, 2024
Git push to origin failed for release/3.8.x with exitcode 1 |
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13566-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13566-to-master-to-upstream
git checkout -b cherry-pick-13566-to-master-to-upstream
ancref=$(git merge-base 168fbc0c97f521e9dcaebd1733fa60e9a7a062de e43812f6d989d9d728853bf0088bb29e1ef8cc63)
git cherry-pick -x $ancref..e43812f6d989d9d728853bf0088bb29e1ef8cc63 |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Aug 26, 2024
Notice this is missing the backport and cherrypicks, @AntoineJac |
3 tasks
kikito
removed
incomplete-backport
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
labels
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport release/3.8.x
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
plugins/ai-proxy
plugins/ai-request-transformer
plugins/ai-response-transformer
size/XS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Same fix than:
https://github.com/Kong/kong-ee/pull/10059/files
Bug fix as request_table could be modified:
https://konghq.atlassian.net/browse/AG-111
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]