Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai): caching use deep copy for request table #13566

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

AntoineJac
Copy link
Contributor

@AntoineJac AntoineJac commented Aug 23, 2024

Summary

Same fix than:
https://github.com/Kong/kong-ee/pull/10059/files
Bug fix as request_table could be modified:
https://konghq.atlassian.net/browse/AG-111

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@flrgh
Copy link
Contributor

flrgh commented Aug 23, 2024

@AntoineJac

Please make the appropriate changes to get this PR in shape for merge:

  • add changelog entry (it's fine to update an existing unreleased changelog entry or omit one if this is a fix for a not-yet-released feature)
  • update the PR title and commit message
  • add a reference to the the jira ticket in the PR description for tracking

@flrgh flrgh requested review from liverpool8056 and removed request for liverpool8056 August 23, 2024 18:42
@AntoineJac AntoineJac changed the title Update handler.lua feat(ai): caching use deep copy for request table Aug 26, 2024
@kikito kikito merged commit e95962d into master Aug 26, 2024
29 checks passed
@kikito kikito deleted the featai-caching-use-deep-copy-for-request-table branch August 26, 2024 10:51
@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.8.x with exitcode 1

@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13566-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13566-to-master-to-upstream
git checkout -b cherry-pick-13566-to-master-to-upstream
ancref=$(git merge-base 168fbc0c97f521e9dcaebd1733fa60e9a7a062de e43812f6d989d9d728853bf0088bb29e1ef8cc63)
git cherry-pick -x $ancref..e43812f6d989d9d728853bf0088bb29e1ef8cc63

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Aug 26, 2024
@kikito
Copy link
Member

kikito commented Aug 26, 2024

Notice this is missing the backport and cherrypicks, @AntoineJac

@kikito kikito removed incomplete-backport incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants