Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): install gcc10 to amazon linux 2 #13631

Closed
wants to merge 1 commit into from

Conversation

bungle
Copy link
Member

@bungle bungle commented Sep 6, 2024

Summary

Building Ada needs C++17 (also simdjson restriction may be removed).

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Sep 6, 2024
@bungle bungle force-pushed the chore/ci-amazon-gcc10 branch 2 times, most recently from 50af69b to 582f880 Compare September 6, 2024 09:04
@pull-request-size pull-request-size bot added size/L and removed size/XS labels Sep 6, 2024
@bungle bungle force-pushed the chore/ci-amazon-gcc10 branch 7 times, most recently from 3a5c1a4 to 8879f63 Compare September 6, 2024 10:34
Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
@fffonion
Copy link
Contributor

fffonion commented Sep 6, 2024

@bungle we can't do this as it may break on the artificats generated and also cross build. let's just skip ada on amazonlinux2 like we did for other projects.

@bungle bungle closed this Sep 9, 2024
@bungle bungle deleted the chore/ci-amazon-gcc10 branch September 9, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants