Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(helpers): move wait functions #13692

Merged
merged 6 commits into from
Sep 20, 2024
Merged

tests(helpers): move wait functions #13692

merged 6 commits into from
Sep 20, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Sep 19, 2024

Summary

KAG-5421

The parameter strategy of vwait_until_no_common_workers() is never used, perhaps we should remove it and clean the code where call it.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 19, 2024
@chronolaw chronolaw marked this pull request as ready for review September 19, 2024 03:17
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 19, 2024
@ADD-SP ADD-SP merged commit 331194f into master Sep 20, 2024
29 checks passed
@ADD-SP ADD-SP deleted the tests/move_wait_funcs branch September 20, 2024 05:27
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13692-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13692-to-master-to-upstream
git checkout -b cherry-pick-13692-to-master-to-upstream
ancref=$(git merge-base 2ba3de19741d416f7c8eafac277e5fc6ccf74d7a 45b22e38ab00dcdbdfba7c169099e45dff235ad8)
git cherry-pick -x $ancref..45b22e38ab00dcdbdfba7c169099e45dff235ad8

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 20, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XXL skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants