chore(build): rename rust target wasm32-wasi to wasm32-wasip1 #13708
+18
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
flrgh
force-pushed
the
chore/wasm-filter-target-rename
branch
from
0b1fef1
to
3f4ebf4
Compare
flrgh
changed the title
team-gateway-bot
added
the
author/community
flrgh
removed
the
author/community
team-gateway-bot
added
the
author/community
flrgh
force-pushed
the
chore/wasm-filter-target-rename
branch
from
3f4ebf4
to
727ea86
Compare
|
@flrgh it looks like this is failing for the build & test step. Does the new wasm32-wasip1 target move the files to a different directory? Maybe target/wasm32-wasip1? |
brentos
approved these changes
Oct 23, 2024
team-eng-enablement
removed
the
author/community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://blog.rust-lang.org/2024/04/09/updates-to-rusts-wasi-targets.html and rust-lang/rust#126662
Note: this only affects filters built/used for integration tests.